Skip to content

Create new production release - #1325

Merged
ebma merged 80 commits into
mainfrom
staging
Aug 10, 2026
Merged

Create new production release#1325
ebma merged 80 commits into
mainfrom
staging

Conversation

@ebma

@ebma ebma commented Aug 7, 2026

Copy link
Copy Markdown
Member

No description provided.

Sharqiewicz and others added 30 commits July 30, 2026 11:03
Resolved 7 conflicts, all where staging's refactors met the email
notification work:

- models/index.ts, vars.ts, phase-processor.ts,
  alfredpay-customer.service.ts: both sides added adjacent declarations;
  kept both. Dropped the TaxId associations, since staging removed that
  model in the provider_customers cutover.
- security-spec/README.md: kept the Resend row, dropped the Stellar
  Anchors row that staging deleted along with the spec file.
- alfredpay.md: both sides added an invariant 24; kept staging's at 24
  and renumbered the notification invariants to 25 and 26.
- brla.md: took staging's anonymous-quote row, which matches the merged
  registerRamp (rejects only when quote and request users both exist and
  differ); this branch's row described pre-cutover behavior. Kept the
  four added webhook threat rows.
ebma added 8 commits August 7, 2026 18:23
…icing-metadata

Add transparent AlfredPay quote pricing metadata
…contract

The dashboard's preference toggles write prefs keyed by these strings and the
API's dispatch worker mutes on them, but each side carried its own literals --
the preferences endpoint accepts arbitrary keys, so drift would mute nothing,
silently. The enum now lives in shared and the API model re-exports it under
its historical NotificationType name.
Review follow-ups on the Settings toggles: a checkbox now reflects
emailEnabled AND the per-type keys, and enabling a category under a global
mute lifts the switch while pinning the other category to its effective
(muted) state. Toggling is blocked until the GET resolves -- a PUT built
from a fallback would replace the saved document -- and while a PUT is in
flight, since overlapping full-document snapshots can complete out of
order. The optimistic handlers are extracted and tested against a real
QueryClient (apply, rollback, no-op without loaded data), and the stale
operations spec that still declared email dispatch unimplemented now
documents the delivery-time preference gating.
…ion-preferences

Wire the Settings email notification toggles to the backend
@netlify

netlify Bot commented Aug 7, 2026

Copy link
Copy Markdown

Deploy Preview for vortex-sandbox ready!

Name Link
🔨 Latest commit 999f3ba
🔍 Latest deploy log https://app.netlify.com/projects/vortex-sandbox/deploys/6a79ffc4a5e45e0008d32f1d
😎 Deploy Preview https://deploy-preview-1325--vortex-sandbox.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify

netlify Bot commented Aug 7, 2026

Copy link
Copy Markdown

Deploy Preview for vrtx-dashboard canceled.

Name Link
🔨 Latest commit 999f3ba
🔍 Latest deploy log https://app.netlify.com/projects/vrtx-dashboard/deploys/6a79ffc4da0a5900081f0052

@netlify

netlify Bot commented Aug 7, 2026

Copy link
Copy Markdown

Deploy Preview for vortexfi ready!

Name Link
🔨 Latest commit 999f3ba
🔍 Latest deploy log https://app.netlify.com/projects/vortexfi/deploys/6a79ffc444313c0007ddf989
😎 Deploy Preview https://deploy-preview-1325--vortexfi.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

ebma added 18 commits August 7, 2026 19:02
Reviews are probabilistic; live integrator breakage should be caught
deterministically. The gate renders the shared endpoint types and the
public SDK API into a structurally expanded snapshot, so any change to
what partners consume - including transitive type/enum drift - fails CI
until the snapshot is regenerated and the diff is reviewed on purpose.
vortex-review encodes the multi-lens finder fleet with loop-until-dry
and adversarial verification; address-feedback turns one PR review
round into a single verify-fix-gate-push command.
ship chains plan approval, implementation with tests, vortex-review
until dry, and PR creation; babysit-pr watches an open PR and reacts
to new reviews and CI failures so feedback rounds need no ferrying.
Copilot review on #1326 found three blind spots: generic conditional
aliases rendered as self-references, signature type parameters and
their constraints were dropped, and readonly was erased. All three
let partner-facing drift pass the gate; the serializer now expands
conditional bodies, emits type-parameter constraints and defaults,
and preserves readonly, with fixture coverage for each.
Inline review comments are not returned by gh pr view and live on a
paginated endpoint; the address-feedback and babysit-pr instructions
now fetch them explicitly so findings cannot be silently dropped.
Second Copilot round on #1326: readonly index signatures and readonly
tuples serialized identically to their mutable forms, so mutability
changes to those constructs would pass the gate unseen.
Review, feedback, and babysit skills execute branch-local commands;
on a public repo with forks that would let an untrusted PR run code
under local credentials. Fork or external-author PRs are now
inspect-only in all three skills.
…ooling

Add wire-contract CI gate and agent review workflow skills
Skills are agent-agnostic capabilities, so they live in the shared
.agents/skills directory alongside the existing integration skills;
.claude/skills keeps symlinks because Claude Code only scans that
path (symlinked skill directories are officially supported). Hook
bypassed for this commit: lint-staged's stash backup fails on staged
symlinks; biome verify was run manually and is clean.
…ation-funding

Make EVM destination funding fee-aware
@ebma
ebma merged commit 713ae6c into main Aug 10, 2026
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants